able to get inner content by utilizing GetJsonValueByPath #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rdiankov
reviewed
Nov 2, 2022
| if(path[0]!='/') { | ||
| path = std::string("/")+field; | ||
| } | ||
| std::string fieldToConstraint = path.substr(1); |
There was a problem hiding this comment.
@cielavenir looks pretty inefficient with creating all these strings on the heap, especially when rapidjson doesn't require std::string
There was a problem hiding this comment.
well, alternative ideas are:
- use GetJsonValueByPath only when field contains "/"
- add a new API named GetPath
|
@ziyan could you check https://github.com/mujin/controllerclientcpp/blob/savebackup/samples/mujinupdatepulseoffset.cpp#L204 ? /cc @kanbouchou Should I add GetPath()? |
|
btw I realized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these will be possible
note that we cannot do
object->Get<map<string, map<string, vector<int>>>>("robot_motion_parameters");. This is C++ limitation.We will use GetJsonValueByPath, so we add leading / to field variable (after copying to temporary variable).